Skip to content

Update bundled musl to 1.2.5 #142682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Gankra
Copy link
Contributor

@Gankra Gankra commented Jun 18, 2025

Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024.


This is a rebase of

Which removes the second speculative commit which ended up not panning out.

I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase.

try-job: dist-x86_64-musl
try-job: dist-i586-gnu-i586-i686-musl
try-job: dist-x86_64-linux

@rustbot
Copy link
Collaborator

rustbot commented Jun 18, 2025

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 18, 2025

These commits modify compiler targets.
(See the Target Tier Policy.)

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

@Gankra
Copy link
Contributor Author

Gankra commented Jun 18, 2025

The previous PR stalled out on concerns of ecosystem breakage, but see this comment for @est31 concluding we can move forward without further mitigation: #125692 (comment)

@Gankra
Copy link
Contributor Author

Gankra commented Jun 18, 2025

I would like to nominate this for FCP or whatever the current process is to land these kinds of major toolchain changes.

Landing this update is expected to resolve ongoing issues in the ecosystem with rootless docker images.

I've also drafted a rust-lang blogpost announcing this change (based on the previous musl update's post).

@jieyouxu
Copy link
Member

jieyouxu commented Jun 18, 2025

The process for bumping the target baseline of Tier 2 targets is currently a Major Change Proposal + FCP (see Changing target baseline (e.g. minimum Darwin or Windows version bump) part). If you draft an MCP, I'll help with the notifying relevant target maintainers part.

Changing target baseline (e.g. minimum Darwin or Windows version bump)

  • Propose using: MCP
  • Approve using: FCP
  • Write an MCP describing why the target should have a change of baseline and once discussion has concluded, an FCP can be started to approve the change of baseline.

@jieyouxu jieyouxu added the needs-mcp This change is large enough that it needs a major change proposal before starting work. label Jun 18, 2025
@jieyouxu
Copy link
Member

r? @wesleywiser (since you've reviewed the previous attempt)

@Gankra
Copy link
Contributor Author

Gankra commented Jun 18, 2025

I have filed an MCP:

@jieyouxu jieyouxu removed the needs-mcp This change is large enough that it needs a major change proposal before starting work. label Jun 18, 2025
@est31 est31 added the relnotes Marks issues that should be documented in the release notes of the next release. label Jun 18, 2025
@Noratrieb Noratrieb added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Jun 18, 2025
@workingjubilee
Copy link
Member

Building host compiler plus musl stds for crater run.

@bors try

bors added a commit that referenced this pull request Jun 19, 2025
Update bundled musl to 1.2.5

Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024.

[musl releases page](https://musl.libc.org/releases.html)

Prior update: #107129

MCP for this change: rust-lang/compiler-team#887

--------

This is a rebase of

* #125692

Which removes the second speculative commit which ended up not panning out.

I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase.

try-job: dist-x86_64-musl
try-job: dist-i586-gnu-i586-i686-musl
try-job: dist-x86_64-linux
@bors
Copy link
Collaborator

bors commented Jun 19, 2025

⌛ Trying commit 1926e11 with merge 1271e16...

@bors
Copy link
Collaborator

bors commented Jun 19, 2025

💥 Test timed out

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@workingjubilee
Copy link
Member

@bors2 delegate=try

@Gankra

This comment was marked as outdated.

@rust-bors

This comment was marked as outdated.

@Gankra

This comment was marked as outdated.

@bors

This comment was marked as outdated.

@Gankra
Copy link
Contributor Author

Gankra commented Jun 19, 2025

@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jun 19, 2025

⌛ Trying commit 1926e11 with merge c066bf6

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 19, 2025
Update bundled musl to 1.2.5

Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024.

* mcp: rust-lang/compiler-team#887
* blog: rust-lang/blog.rust-lang.org#1641
* Prior update: #107129
* [musl releases page](https://musl.libc.org/releases.html)

--------

This is a rebase of

* #125692

Which removes the second speculative commit which ended up not panning out.

I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase.

try-job: dist-x86_64-musl
try-job: dist-i586-gnu-i586-i686-musl
try-job: dist-x86_64-linux
@Gankra
Copy link
Contributor Author

Gankra commented Jun 19, 2025

It's been so long my old friend... or perhaps the grandchild of my old friend......

@jieyouxu
Copy link
Member

jieyouxu commented Jun 19, 2025

For whatever reason, that timed out job built LLVM in 4 hours and 11 minutes, and when the dist toolchain build time (probably a bit more than 2 hours) is added on top, we hit the 6 hours job timeout limit.

(Discussed in #t-infra > molasses dist-x86_64-musl try-build)

@rust-bors
Copy link

rust-bors bot commented Jun 20, 2025

☀️ Try build successful (CI)
Build commit: c066bf6 (c066bf6804adc55193b71afdff6a56922f4a8689, parent: 8de4c7234dd9b97c9d76b58671343fdbbc9a433e)

@workingjubilee
Copy link
Member

@craterbot run mode=build-and-test name=musl_upgrade_1_2_5_in_2025 start=try#8de4c7234dd9b97c9d76b58671343fdbbc9a433e+target=x86_64-unknown-linux-musl end=try#c066bf6804adc55193b71afdff6a56922f4a8689+target=x86_64-unknown-linux-musl

@craterbot
Copy link
Collaborator

👌 Experiment musl_upgrade_1_2_5_in_2025 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2025
@craterbot
Copy link
Collaborator

🚧 Experiment musl_upgrade_1_2_5_in_2025 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Mark-Simulacrum
Copy link
Member

@craterbot abort

Yielding to #141588 (comment) which is time sensitive (needed for release later this week).

@craterbot
Copy link
Collaborator

🗑️ Experiment musl_upgrade_1_2_5_in_2025 deleted!

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jun 22, 2025
@Mark-Simulacrum
Copy link
Member

@craterbot run mode=build-and-test name=musl_upgrade_1_2_5_in_2025-retry-1 start=try#8de4c7234dd9b97c9d76b58671343fdbbc9a433e+target=x86_64-unknown-linux-musl end=try#c066bf6804adc55193b71afdff6a56922f4a8689+target=x86_64-unknown-linux-musl

@craterbot
Copy link
Collaborator

👌 Experiment musl_upgrade_1_2_5_in_2025-retry-1 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2025
@craterbot
Copy link
Collaborator

🚧 Experiment musl_upgrade_1_2_5_in_2025-retry-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment musl_upgrade_1_2_5_in_2025-retry-1 is completed!
📊 10093 regressed and 131 fixed (652296 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jun 25, 2025
@jieyouxu
Copy link
Member

Crater problem is known: #t-infra > crater: >100k "prepare-fail" crates?.

@est31
Copy link
Member

est31 commented Jun 25, 2025

Link to prior run. Just looking at the numbers:

Jul 2024 June 25 2025
regressed 11788 10093
total 482394 652296
percent 2.4% 1.5%

Assuming those 20% crates that we don't have results from have the same distribution of regressions (not sure that's how crater works!), we'd have 12111 regressed crates in total, or 1.8%. The 3% rise in the absolute number of regressions is probably within the error of that extrapolation method.

The number of total crates has risen by 35%. So one could say we outgrow the problem by just having the group of public projects grow :). Probably the earlier crater run already selected for the tail of projects that basically never do cargo update, given that back then the libc release had been out for almost a year already.

With the numbers of the earlier crater run we already said we are going to do the upgrade. I think these too should allow the same conclusion.

@workingjubilee
Copy link
Member

hmm, is there a patch or something we can apply while using crater to force-update the getrandom users? then we can retry just the regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.