-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Update bundled musl to 1.2.5 #142682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update bundled musl to 1.2.5 #142682
Conversation
These commits modify compiler targets. Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb |
The previous PR stalled out on concerns of ecosystem breakage, but see this comment for @est31 concluding we can move forward without further mitigation: #125692 (comment) |
I would like to nominate this for FCP or whatever the current process is to land these kinds of major toolchain changes. Landing this update is expected to resolve ongoing issues in the ecosystem with rootless docker images. I've also drafted a rust-lang blogpost announcing this change (based on the previous musl update's post). |
The process for bumping the target baseline of Tier 2 targets is currently a Major Change Proposal + FCP (see Changing target baseline (e.g. minimum Darwin or Windows version bump) part). If you draft an MCP, I'll help with the notifying relevant target maintainers part.
|
r? @wesleywiser (since you've reviewed the previous attempt) |
I have filed an MCP: |
Building host compiler plus musl stds for crater run. @bors try |
Update bundled musl to 1.2.5 Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024. [musl releases page](https://musl.libc.org/releases.html) Prior update: #107129 MCP for this change: rust-lang/compiler-team#887 -------- This is a rebase of * #125692 Which removes the second speculative commit which ended up not panning out. I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase. try-job: dist-x86_64-musl try-job: dist-i586-gnu-i586-i686-musl try-job: dist-x86_64-linux
💥 Test timed out |
@bors2 delegate=try |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@bors2 try |
Update bundled musl to 1.2.5 Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024. * mcp: rust-lang/compiler-team#887 * blog: rust-lang/blog.rust-lang.org#1641 * Prior update: #107129 * [musl releases page](https://musl.libc.org/releases.html) -------- This is a rebase of * #125692 Which removes the second speculative commit which ended up not panning out. I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase. try-job: dist-x86_64-musl try-job: dist-i586-gnu-i586-i686-musl try-job: dist-x86_64-linux
It's been so long my old friend... or perhaps the grandchild of my old friend...... |
For whatever reason, that timed out job built LLVM in 4 hours and 11 minutes, and when the dist toolchain build time (probably a bit more than 2 hours) is added on top, we hit the 6 hours job timeout limit. (Discussed in #t-infra > molasses dist-x86_64-musl try-build) |
@craterbot run mode=build-and-test name=musl_upgrade_1_2_5_in_2025 start=try#8de4c7234dd9b97c9d76b58671343fdbbc9a433e+target=x86_64-unknown-linux-musl end=try#c066bf6804adc55193b71afdff6a56922f4a8689+target=x86_64-unknown-linux-musl |
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
@craterbot abort Yielding to #141588 (comment) which is time sensitive (needed for release later this week). |
🗑️ Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
@craterbot run mode=build-and-test name=musl_upgrade_1_2_5_in_2025-retry-1 start=try#8de4c7234dd9b97c9d76b58671343fdbbc9a433e+target=x86_64-unknown-linux-musl end=try#c066bf6804adc55193b71afdff6a56922f4a8689+target=x86_64-unknown-linux-musl |
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🎉 Experiment
|
Crater problem is known: #t-infra > crater: >100k "prepare-fail" crates?. |
Link to prior run. Just looking at the numbers:
Assuming those 20% crates that we don't have results from have the same distribution of regressions (not sure that's how crater works!), we'd have 12111 regressed crates in total, or 1.8%. The 3% rise in the absolute number of regressions is probably within the error of that extrapolation method. The number of total crates has risen by 35%. So one could say we outgrow the problem by just having the group of public projects grow :). Probably the earlier crater run already selected for the tail of projects that basically never do With the numbers of the earlier crater run we already said we are going to do the upgrade. I think these too should allow the same conclusion. |
hmm, is there a patch or something we can apply while using crater to force-update the getrandom users? then we can retry just the regressions. |
Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024.
*-linux-musl
targets to musl 1.2.5 compiler-team#887*-linux-musl
targets to 1.2.3 #107129This is a rebase of
Which removes the second speculative commit which ended up not panning out.
I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase.
try-job: dist-x86_64-musl
try-job: dist-i586-gnu-i586-i686-musl
try-job: dist-x86_64-linux